Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows installation #451

Closed

Conversation

mabelzhang
Copy link
Collaborator

@mabelzhang mabelzhang commented Dec 24, 2020

Partially addresses gazebosim/docs#117

Should I target sdf10 or master? Let me know if I need to retarget.

Is ignition-tools an optional dependency? I saw a warning in CMake but didn’t see it in CMakeLists.txt.

I don't have permissions in this repo to request reviewers @chapulina @JShep1

Signed-off-by: Mabel Zhang <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🔮 dome Ignition Dome labels Dec 24, 2020
@codecov-io
Copy link

codecov-io commented Dec 24, 2020

Codecov Report

Merging #451 (c55255d) into sdf10 (7dbf121) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            sdf10     #451   +/-   ##
=======================================
  Coverage   87.54%   87.54%           
=======================================
  Files          61       61           
  Lines        9357     9357           
=======================================
  Hits         8192     8192           
  Misses       1165     1165           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dbf121...c55255d. Read the comment docs.

Signed-off-by: Mabel Zhang <[email protected]>
@chapulina chapulina added documentation Improvements or additions to documentation Windows Windows support labels Dec 28, 2020
@chapulina chapulina self-requested a review December 28, 2020 19:22
@JShep1
Copy link

JShep1 commented Jan 1, 2021

Do we want to add Windows binary install also? The package name would be libsdformat<#>

@mabelzhang
Copy link
Collaborator Author

Closing in favor of #463

@mabelzhang mabelzhang closed this Jan 14, 2021
@mabelzhang mabelzhang deleted the mabelzhang/windows_install branch January 14, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants